[Mesa-dev] [PATCH] genxml: Handle failure of Python codegen scripts.

[Jason Ekstrand]

On Oct 26, 2016 12:51 PM, "Matt Turner" <mattst88 at gmail.com> wrote:
>
> ---
>  src/intel/Makefile.genxml.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am
> index 2df223a..2ed2741 100644
> --- a/src/intel/Makefile.genxml.am
> +++ b/src/intel/Makefile.genxml.am
> @@ -33,7 +33,7 @@ $(GENXML_GENERATED_FILES): genxml/gen_pack_header.py
>
>  .xml_pack.h:
>         $(MKDIR_GEN)
> -       $(PYTHON_GEN) $(srcdir)/genxml/gen_pack_header.py $< > $@
> +       $(PYTHON_GEN) $(srcdir)/genxml/gen_pack_header.py $< > $@ ||
($(RM) $@; false)

Thanks for fixing this!  I think the way we do this most other places is
with "> $@.tmp && mv $@.tmp $&” not that I care that much...

>  # xxd generates variable names based on the path of the input file. We
>  # prefer to generate our own name here, so it doesn't vary from
> --
> 2.7.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161026/9eff9ff1/attachment-0001.html>