[Mesa-dev] [PATCH] i965: do not release GLSL IR for SSO programs

Kenneth Graunke kenneth at whitecape.org
Fri Oct 28 01:51:31 UTC 2016

On Thursday, October 27, 2016 9:03:12 PM PDT Timothy Arceri wrote:
> On Thu, 2016-10-27 at 12:37 +1100, Timothy Arceri wrote:
> > Agreed but as far as I can tell we shouldn't even need
> > gl_linked_shader
> > after glLinkProgram.
> > 
> > We should probably just free it after linking. Everything we want
> > *should* have been copied to gl_program, however in practice it seems
> > there are some things we still get from gl_linked_shader
> > like NumImages, but with the changes I landed recently we could just
> > be getting this from the new shader_info struct.
> I've started work on this:
> https://patchwork.freedesktop.org/series/14471/
> But I'm not sure I have is in me to do another big refactor right now. 

Is there a reasonable short-term fix?  This regression is present on
the 13.0 branch and we really ought to fix it before Emil cuts the 13.0
final release.  But it'd be nice if we could keep some freeing of IR...

Refactoring is probably a good idea in the longer term....

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161027/f5252bcd/attachment.sig>

More information about the mesa-dev mailing list