[Mesa-dev] [PATCH] drivers/meta: Accept GL_TEXTURE_3D as target for tex image decompression

[Kenneth Graunke]

On Tuesday, October 18, 2016 9:55:38 AM PDT Eduardo Lima Mitev wrote:
> An assert is currently raised, preventing decompression of a texture image into
> a GL_TEXTURE_3D target. I have not found any spec wording that would explain
> this, or implementation detail that would prevent it. And in any case, the
> driver should not cause a crash upon user input arguments.
> 
> Fixes most failing subcases in CTS tests:
> * GL44-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pixelstore
> * GL45-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pixelstore
> 
> These tests were crashing the driver before. Now they just fail, but due
> to an unrelated issue affecting 2 out of the 45 test subcases.
> 
> No regressions observed against piglit or CTS-GL.
> ---
>  src/mesa/drivers/common/meta.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c
> index 890e98a..0d8c667 100644
> --- a/src/mesa/drivers/common/meta.c
> +++ b/src/mesa/drivers/common/meta.c
> @@ -3026,10 +3026,6 @@ decompress_texture_image(struct gl_context *ctx,
>        assert(!"No compressed 1D textures.");
>        return false;
>  
> -   case GL_TEXTURE_3D:
> -      assert(!"No compressed 3D textures.");
> -      return false;
> -
>     case GL_TEXTURE_CUBE_MAP_ARRAY:
>        faceTarget = GL_TEXTURE_CUBE_MAP_POSITIVE_X + (slice % 6);
>        break;
> 

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

and pushed:

To ssh://git.freedesktop.org/git/mesa/mesa
   43dadb6..c064803  master -> master
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161028/4beb654f/attachment.sig>