[Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

Lionel Landwerlin lionel.g.landwerlin at intel.com
Fri Oct 28 18:18:43 UTC 2016


On 28/10/16 19:12, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> There is nothing in here that would require it.
>
> Cc: mesa-stable at lists.freedesktop.org
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Not sure why we got that dependency in the first place, Lionel ?

Some of the Makefile's content ends up in the header (the last echo line 
of this patch).
If someone changes that, it's nice not to have to cleanup all the intel 
directory

> ---
>   src/intel/Makefile.genxml.am | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/intel/Makefile.genxml.am b/src/intel/Makefile.genxml.am
> index f998011..e23702f 100644
> --- a/src/intel/Makefile.genxml.am
> +++ b/src/intel/Makefile.genxml.am
> @@ -39,8 +39,6 @@ $(GENXML_GENERATED_FILES): genxml/gen_pack_header.py
>   # prefer to generate our own name here, so it doesn't vary from
>   # in/out-of-tree builds.
>   
> -$(GENXML_GENERATED_FILES): Makefile
> -
>   .xml_xml.h:
>   	$(MKDIR_GEN)
>   	$(AM_V_GEN) echo -n "static const uint8_t " > $@; \




More information about the mesa-dev mailing list