[Mesa-dev] [PATCH 2/2] intel/genxml: automake: drop Makefile dependency for the _xml.h target

Emil Velikov emil.l.velikov at gmail.com
Fri Oct 28 20:42:15 UTC 2016


On 28 October 2016 at 20:55, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 28 October 2016 at 19:18, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> On 28/10/16 19:12, Emil Velikov wrote:
>>>
>>> From: Emil Velikov <emil.velikov at collabora.com>
>>>
>>> There is nothing in here that would require it.
>>>
>>> Cc: mesa-stable at lists.freedesktop.org
>>> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>>> ---
>>> Not sure why we got that dependency in the first place, Lionel ?
>>
>>
>> Some of the Makefile's content ends up in the header (the last echo line of
>> this patch).
>> If someone changes that, it's nice not to have to cleanup all the intel
>> directory
>>
> Valid point. At the same time, this applies to every rule [we have in
> mesa] and we don't bother anywhere else.
>
Upon some testing/thinking I think we should nuke it.

Reason being that as one runs ./configure the Makefile is generated.
Thus the files will be generated regardless if a) we're a release
tarball where the files are already present and b) we do (or don't)
have the tool to regenerate them to begin with.

-Emil


More information about the mesa-dev mailing list