[Mesa-dev] [PATCH 1/8] intel: Add a new "common" library for more code sharing

[Rob Herring]

On Wed, Aug 31, 2016 at 3:56 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
> The first thing to go in this new library is brw_device_info.
>
> Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
> Cc: Rob Herring <robh at kernel.org>
> ---
>
> The android build files I just copied-and-pasted from blorp but I don't
> have an android build setup so I can't test them.

Tested-by: Rob Herring <robh at kernel.org>

Took longer than I expected because there's an unrelated breakage in
glsl. Patch coming for that one.

A couple of nits though...

[...]

> +
> +include $(CLEAR_VARS)
> +
> +LOCAL_MODULE := libintel_common

For consistency: libmesa_intel_common

> +
> +LOCAL_MODULE_CLASS := STATIC_LIBRARIES
> +
> +LOCAL_SRC_FILES := $(COMMON_FILES)
> +
> +LOCAL_C_INCLUDES :=

This line is not needed.

> +
> +include $(MESA_COMMON_MK)
> +include $(BUILD_STATIC_LIBRARY)

Rob