[Mesa-dev] [PATCH 2/9] glsl: Use the ir_intrinsic_* enums instead of the __intrinsic_* name strings

Ilia Mirkin imirkin at alum.mit.edu
Thu Sep 1 18:15:27 UTC 2016


On Thu, Sep 1, 2016 at 2:10 PM, Ian Romanick <idr at freedesktop.org> wrote:
> +      case ir_intrinsic_atomic_counter_comp_swap: {
>           opcode = TGSI_OPCODE_ATOMCAS;
>           param = param->get_next();
>           val = ((ir_instruction *)param)->as_rvalue();
>           val->accept(this);
>           data2 = this->result;
> -      } else if (!strcmp("__intrinsic_atomic_sub", callee)) {
> +         break;
> +      }
> +      case ir_intrinsic_atomic_sub: {

I think you meant ir_intrinsic_atomic_counter_sub, and a similar issue
in the commit where you remove it.

>           opcode = TGSI_OPCODE_ATOMUADD;
>           st_src_reg res = get_temp(glsl_type::uvec4_type);
>           st_dst_reg dstres = st_dst_reg(res);
>           dstres.writemask = dst.writemask;
>           emit_asm(ir, TGSI_OPCODE_INEG, dstres, data);
>           data = res;
> -      } else {
> +         break;
> +      }


More information about the mesa-dev mailing list