[Mesa-dev] [Bug 97587] make check nir/tests/control_flow_tests regression

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Sat Sep 3 18:00:23 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=97587

            Bug ID: 97587
           Summary: make check nir/tests/control_flow_tests regression
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Mesa core
          Assignee: mesa-dev at lists.freedesktop.org
          Reporter: vlee at freedesktop.org
        QA Contact: mesa-dev at lists.freedesktop.org

aad4f15506c2b5ff9f3304a467b51b45dd77554d is the first bad commit
commit aad4f15506c2b5ff9f3304a467b51b45dd77554d
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Wed Aug 31 14:45:08 2016 -0700

    nir: Remove fake edges in the CF handling code

    When NIR was first introduced, Connor added this fake-edge hack to work
    around issues related to unreachable blocks.  Thanks to GLSL IR's jump
    lowering code, the only unreachable code you can have is a block after an
    infinite loop.  With SPIR-V, we didn't have the jump lowering code so we
    could also end up with the "if (...) { break; } else { continue; }" case
    which generates an unreachable block after the if.  Because of this, most
    of NIR had to be fixed up for handling unreachable blocks.  The only
    remaining case of not handling unreachable blocks was specifically the
    block-after-infinite-loop case in dead_cf which was fixed by the previous
    commit.  We can now delete the fake edge hack.

    Signed-off-by: Jason Ekstrand <jason at jlekstrand.net>
    Reviewed-by: Connor Abbott <cwabbott0 at gmail.com>

:040000 040000 b084afb90cdcfa37be94c6b8edeab3fea8076faf
d3ed6d3db2f7e9b62b8f4da952e0e768cb6f8856 M src
bisect run success

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160903/4fba88c5/attachment-0001.html>


More information about the mesa-dev mailing list