[Mesa-dev] Issue with using _mesa_has_* helpers that are only for GLL and not GLC

[Ilia Mirkin]

Actually I ended up fixing this up:

https://patchwork.freedesktop.org/patch/108725/

On Fri, Sep 2, 2016 at 2:53 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Matteo pointed out on IRC that we fail to report some format query
> stuff for GL_TEXTURE_CUBE_MAP because we check for
> _mesa_has_ARB_texture_cube_map(). However that ext isn't available in
> core (per our extension_table.h definitions), so the helper returns
> false. Looking at all of the instances of such a situation, here is
> what I found:
>
> $ git grep -f <(grep 'GLL,\s*x' src/mesa/main/extensions_table.h | cut
> -f1 -d ' ' | cut -f2 -d '(' | sed 's/^/_mesa_has_/' | sed 's/$/\(/') |
> cat
> src/mesa/main/formatquery.c:      if (!_mesa_has_ARB_texture_cube_map(ctx))
> src/mesa/main/formatquery.c:      if (!_mesa_has_NV_texture_rectangle(ctx))
> src/mesa/main/formatquery.c:         if (!_mesa_has_ARB_depth_texture(ctx) &&
>
>
> I have no immediate plans to fix these, but figured I'd make my
> findings available. Looks like only the formatquery.c logic is ever
> affected.
>
> Cheers,
>
>   -ilia