[Mesa-dev] [PATCH] mesa/formatquery: limit ES target support, fix core context support

Matteo Bruni matteo.mystral at gmail.com
Sat Sep 3 20:00:41 UTC 2016


2016-09-03 21:11 GMT+02:00 Ilia Mirkin <imirkin at alum.mit.edu>:
> First off, as late as ES 3.2, GetInternalformat only supports
> RENDERBUFFER and 2DMS(_ARRAY) targets.
>
> Secondly, the _mesa_has_ext helpers are very accurate... a little too
> accurate, some might say. If we only show an extension in compat
> profiles because core profiles have the functionality guaranteed, they
> will return false. Fix these to either check for a core profile
> explicitly, or to a different-but-identical extension available in core
> profile.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> Cc: mesa-stable at lists.freedesktop.org

I also wrote a patch for this bug, essentially identical except yours
has that couple of additional ES changes. Your patch looks good and it
works for me so, FWIW, have my

Reviewed-by: Matteo Bruni <matteo.mystral at gmail.com>
Tested-by: Matteo Bruni <matteo.mystral at gmail.com>


More information about the mesa-dev mailing list