[Mesa-dev] [PATCH] loader/dri3: Always use at least two back buffers

Michel Dänzer michel at daenzer.net
Tue Sep 6 02:39:42 UTC 2016


From: Michel Dänzer <michel.daenzer at amd.com>

This can make a significant difference for performance with some extreme
test cases such as vblank_mode=0 glxgears.

Fixes: 1e3218bc5ba2 ("loader/dri3: Overhaul dri3_update_num_back")
Cc: "12.0 11.2" <mesa-stable at lists.freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97549
Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
---

I could swear I tested vblank_mode=0 glxgears with my previous change
and couldn't measure any difference, but I can now, so I must have
messed up my previous testing somehow... Apologies for any inconvenience
this caused.

 src/loader/loader_dri3_helper.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c
index 86ae5ae..3ce0352 100644
--- a/src/loader/loader_dri3_helper.c
+++ b/src/loader/loader_dri3_helper.c
@@ -70,10 +70,8 @@ dri3_update_num_back(struct loader_dri3_drawable *draw)
 {
    if (draw->flipping)
       draw->num_back = 3;
-   else if (draw->vtable->get_swap_interval(draw) != 0)
-      draw->num_back = 2;
    else
-      draw->num_back = 1;
+      draw->num_back = 2;
 }
 
 void
-- 
2.9.3



More information about the mesa-dev mailing list