[Mesa-dev] [v2 5/6] isl/gen8+: Allow 1D and 3D auxiliary surfaces

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Tue, Sep 6, 2016 at 12:28 AM, Topi Pohjolainen <
topi.pohjolainen at gmail.com> wrote:

> Otherwise once mcs buffer gets allocated without delay for lossless
> compression (same as we do for msaa), assert starts to fire in
> piglit case: tex3d. The test uses depth of one which is in fact
> supported even now.
>
> v2 (Jason): Allow also 1D case as there is nothing in the specs
>             constraining it either.
>
> Signed-off-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/intel/isl/isl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index c7639d0..3dfdf20 100644
> --- a/src/intel/isl/isl.c
> +++ b/src/intel/isl/isl.c
> @@ -1329,7 +1329,8 @@ isl_surf_get_ccs_surf(const struct isl_device *dev,
>     assert(surf->samples == 1 && surf->msaa_layout ==
> ISL_MSAA_LAYOUT_NONE);
>     assert(ISL_DEV_GEN(dev) >= 7);
>
> -   assert(surf->dim == ISL_SURF_DIM_2D);
> +   assert(ISL_DEV_GEN(dev) >= 8 || surf->dim == ISL_SURF_DIM_2D);
> +
>     assert(surf->logical_level0_px.depth == 1);
>
>     /* TODO: More conditions where it can fail. */
> --
> 2.5.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160906/d01f6943/attachment.html>