[Mesa-dev] [PATCH 0/3] nir: Add value number to GCM

Jason Ekstrand jason at jlekstrand.net
Tue Sep 6 18:08:55 UTC 2016


This little series adds value numbering support to the global code motion
pass.  All of the patches have my name on them but most of the credit goes
to Connor and his instruction set.  The instruction set was originally
written for GVN but we merged it a while ago because we can also use it for
regular CSE and it is much more efficient than the old list-based approach.
Now that it's merged GVN is just a couple of lines.

I'm not going to recommend that we merge patch 3 yet.  There are still some
regressions with it and we should try and get that sorted out.  That said,
at some point, we just need to say "good enough", eat the costs, and enjoy
the over-all benifit.  That time may not yet have come though, so I won't
push for turning it on.

That said, I would like to merge the first two patches so they aren't
floating around in my branch having to be rebased anymore.

Jason Ekstrand (3):
  nir/gcm: Call nir_metadata_preserve
  nir/gcm: Add value numbering support
  i965/nir: Use GCM and GVN

 src/compiler/nir/nir.h              |  2 +-
 src/compiler/nir/nir_opt_gcm.c      | 32 +++++++++++++++++++++++++++-----
 src/mesa/drivers/dri/i965/brw_nir.c |  1 +
 3 files changed, 29 insertions(+), 6 deletions(-)

-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list