[Mesa-dev] [PATCH] glsl: use hash instead of exec_list in copy propagation

[Jason Ekstrand]

On Tue, Sep 6, 2016 at 11:14 AM, Eric Anholt <eric at anholt.net> wrote:

> Tapani Pälli <tapani.palli at intel.com> writes:
>
> > This change makes copy propagation pass faster. Complete link time
> > spent in test case attached to bug 94477 goes down to ~400 secs from
> > over 500 secs on my HSW machine. Does not fix the actual issue but
> > brings down the total. No regressions seen in CI.
> >
> > Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> > ---
> >
> > Next I'll attempt to make similar change to
> opt_copy_propagation_elements.
>
> This all looks correct, though it makes me sad to see work being done on
> these passes instead of just removing them from being called by NIR
> drivers.
>

Sadly, I think copy-prop is one of the ones that will never go away since
we need it for evaluating GLSL stuff that we have to be able to validate at
link time.  That said, if the 500 seconds is coming because of channel
expressions.... That one needs to die.


> Reviewed-by: Eric Anholt <eric at anholt.net>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160906/2d96da45/attachment.html>