[Mesa-dev] [PATCH v3] clover: Introduce CLOVER_EXTRA_COMPILER_OPTIONS

[Serge Martin]

On Wednesday 07 September 2016 19:28:36 Serge Martin wrote:
> On Wednesday 07 September 2016 18:37:51 Vedran Miletić wrote:
> > On 09/07/2016 04:14 PM, Jan Vesely wrote:
> > > On Wed, 2016-09-07 at 13:43 +0200, Vedran Miletić wrote:
> > >> Options specified via the CLOVER_EXTRA_COMPILER_OPTIONS shell
> > >> variable
> > >> are appended to the compiler and linker options specified by the
> > >> OpenCL
> > >> program (if any).
> > >> 
> > >> v2:
> > >>  * rename to CLOVER_EXTRA_COMPILER_OPTIONS
> > >>  * use debug_get_option
> > >>  * append to linker options as well
> > > 
> > > is this safe? sets of recognized compiler and linker options are
> > > distinct, so there's a risk of getting
> > > CL_INVALID_COMPILER_OPTION/CL_INVALID_LINKER_OPTION if the env var
> > > includes options that is permitted by one and not the other.
> > > 
> > > since this is a debug mechanism I'm OK if it just produces warning.
> > > 
> > > Jan
> > 
> > Indeed. We could use CLOVER_EXTRA_LINKER_OPTIONS then. v4 incoming.
> 
> As I said before, clover been CL1.1, the same option are pass both to clBuid
> and clLink, anyway...

anyway, the args are parsed using the same LLVM function so that shouldn't be 
a problem if we use the same env variable.
And as a matter of fact, only the optimization level is used when linking, so 
I prefer that we stick to one env variable.

> 
> > Regards,
> > Vedran
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev