[Mesa-dev] [PATCH 0/6] intel/isl: A few cleanups for multisampled HiZ

[Jason Ekstrand]

On Sep 7, 2016 12:27 PM, "Nanley Chery" <nanleychery at gmail.com> wrote:
>
> On Fri, Sep 02, 2016 at 03:50:41PM -0700, Jason Ekstrand wrote:
> > This series does a few cleanups to ISL so that it can actually handle
> > multisampled HiZ correctly.  When Chad and I first discussed HiZ, we
> > thought it would all work out easy as ISL already had all the required
> > code.  We were correct that it had all the required code but wrong about
> > the easy part.  It turns out that there were some troublesome asserts
and
> > the choose_tiling and choose_msaa_layout paths weren't 100% HiZ
friendly at
> > least not when mutlisampling gets involved.
> >
> > This little series cleans things up a bit and gets multisampled HiZ
> > working.  In the end, I'm very happy with these changes as I think
they're
> > almost all good changes even without HiZ.
> >
> > This series can replace patch 02/12 of Nanley's recent HiZ series.
>
> Doesn't this also need to add support for 3D textures in
> isl_surf_get_hiz_surf() to replace that patch?

Yes, we will need a patch that fixes up the asserts.  Surprisingly, this
series plus a revert of your "Update get_hiz_surf" patch passes the CTS...

> >
> > Jason Ekstrand (6):
> >   intel/isl: Add a format_supports_multisampling helper
> >   intel/isl: Fix up asserts in calc_phys_level0_extent_sa
> >   intel/isl: Allow multisampling with ISL_FORMAT_HiZ
> >   intel/isl: Handle HiZ and CCS tiling more directly
> >   intel/isl: Remove tiling checks from choose_msaa_layout
> >   intel/isl: Add a detailed comment about multisampling with HiZ
> >
> >  src/intel/isl/isl.c        | 83
++++++++++++++++++++++++++++++++++++++++++----
> >  src/intel/isl/isl.h        |  2 ++
> >  src/intel/isl/isl_format.c | 35 +++++++++++++++++++
> >  src/intel/isl/isl_gen6.c   | 19 +----------
> >  src/intel/isl/isl_gen7.c   | 40 +++++-----------------
> >  src/intel/isl/isl_gen8.c   | 15 +--------
> >  6 files changed, 123 insertions(+), 71 deletions(-)
> >
> > --
> > 2.5.0.400.gff86faf
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160907/c7823810/attachment.html>