[Mesa-dev] [PATCH 49/57] i965/vec4: Check that the write offsets match when setting dependency controls.

Francisco Jerez currojerez at riseup.net
Thu Sep 8 01:49:16 UTC 2016


For simplicity just assume that two writes to the same GRF with
different sub-GRF offsets will potentially interfere and break the
dependency control chain.  This is in preparation for adding sub-GRF
offset support to the VEC4 IR.
---
 src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp
index dc484ba..f97de18 100644
--- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
@@ -980,6 +980,7 @@ vec4_visitor::opt_set_dependency_control()
          int reg = inst->dst.nr + inst->dst.offset / REG_SIZE;
          if (inst->dst.file == VGRF || inst->dst.file == FIXED_GRF) {
             if (last_grf_write[reg] &&
+                last_grf_write[reg]->dst.offset == inst->dst.offset &&
                 !(inst->dst.writemask & grf_channels_written[reg])) {
                last_grf_write[reg]->no_dd_clear = true;
                inst->no_dd_check = true;
@@ -991,6 +992,7 @@ vec4_visitor::opt_set_dependency_control()
             grf_channels_written[reg] |= inst->dst.writemask;
          } else if (inst->dst.file == MRF) {
             if (last_mrf_write[reg] &&
+                last_mrf_write[reg]->dst.offset == inst->dst.offset &&
                 !(inst->dst.writemask & mrf_channels_written[reg])) {
                last_mrf_write[reg]->no_dd_clear = true;
                inst->no_dd_check = true;
-- 
2.9.0



More information about the mesa-dev mailing list