[Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

Emil Velikov emil.l.velikov at gmail.com
Thu Sep 8 15:51:39 UTC 2016


On 8 September 2016 at 04:29, Chad Versace <chadversary at chromium.org> wrote:
> The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so.
> But it's needed only if HAVE_PLATFORM_X11.
>
> Fixes build of libvulkan_intel.so on Chromium OS, which has no X11
> libraries.
>
Pretty sure that was the "must fix" part of my review comment ;-)

> Cc: Kevin Strasser <kevin.strasser at intel.com>
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> Change-Id: Ib42db7db582c4531cf13db65f2ad5d57db1d774d
Please drop this ?

Fixes: 71258e9462c ("anv/x11: Add support for Xlib platform")
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks
Emil


More information about the mesa-dev mailing list