[Mesa-dev] [PATCH 3/7] EGL: Implement remaining functions from EGL_KHR_debug

[Emil Velikov]

On 8 September 2016 at 19:10, Adam Jackson <ajax at redhat.com> wrote:
> On Thu, 2016-09-08 at 11:57 -0600, Kyle Brenneman wrote:
>> This one has the a bug in it where it doesn't set the callback if
>> (attrib_list == NULL), plus the more minor bug where it doesn't check
>> for invalid attributes if (callback == NULL). The first one is the same
>> bug you noticed in libglvnd, which got copied over when I adapted it for
>> Mesa. I can fix that and send out an updated patch if you like, or if
>> it's easier, I can add a commit to the end of this list.
>>
>
> Hah, indeed. Patch at the end of this series is probably easiest.
>
git commit --fixup=$sha && git rebase --autosquash isn't that bad either, no ?

While you're there, can you please drop all the unneeded brackets in
eglDebugMessageControlKHR and eglQueryDebugKHR, and fix the
indentation if the former.

Thanks
Emil