[Mesa-dev] [PATCH] glsl: Add a citation for uniform precision matching.

Eric Anholt eric at anholt.net
Fri Sep 9 19:20:02 UTC 2016


Ian Romanick <idr at freedesktop.org> writes:

> On 09/06/2016 03:24 PM, Kenneth Graunke wrote:
>> On Tuesday, September 6, 2016 1:04:43 PM PDT Eric Anholt wrote:
>>> Kenneth Graunke <kenneth at whitecape.org> writes:
>>>
>>>> Ian added this check in commit 259fc505454ea6a67aeacf6cdebf1398d9947759.
>>>> While reviewing the rules, I found a citation which spells this out
>>>> clearly, so I figured I'd send a patch to add it as a comment.
>>>>
>>>> Cc: idr at freedesktop.org
>>>> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
>>>
>>> Reviewed-by: Eric Anholt <eric at anholt.net>
>>>
>>> I was wondering about this change, because glmark2 is failing to compile
>>> its terrain shaders now.
>
> Out of curiosity... is the uniform used in all the stages?

In glmark2 -b terrain, it's defined but not used in VS.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160909/a8ae01d2/attachment-0001.sig>


More information about the mesa-dev mailing list