[Mesa-dev] [PATCH] tgsi: document semantics for compute shaders

[Samuel Pitoiset]

On 09/10/2016 05:01 PM, Ilia Mirkin wrote:
> On Sat, Sep 10, 2016 at 10:05 AM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> Cc: Nicolai Hähnle <nicolai.haehnle at amd.com>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>  src/gallium/docs/source/tgsi.rst | 26 ++++++++++++++++++++++++++
>>  1 file changed, 26 insertions(+)
>>
>> diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst
>> index c6e5ceb..d83cf9a 100644
>> --- a/src/gallium/docs/source/tgsi.rst
>> +++ b/src/gallium/docs/source/tgsi.rst
>> @@ -3054,6 +3054,32 @@ parameter to the clEnqueueNDRangeKernel call with which the shader
>>  was started.
>>
>>
>> +TGSI_SEMANTIC_GRID_SIZE
>> +"""""""""""""""""""""""
>> +
>> +For compute shaders, this semantic indicates the maximum dimensions (x, y, z)
>> +of a grid of thread blocks.
>> +
>> +
>> +TGSI_SEMANTIC_BLOCK_ID
>> +""""""""""""""""""""""
>> +
>> +For compute shaders, this semantic indicates the id of the current block.
>
> IMHO this (and similar for THREAD_ID) would be clearer as
>
> "... indicates the (x, y, z) coordinates of the current block inside
> of the grid."

Looks better, I will send a new version.

>
>> +
>> +
>> +TGSI_SEMANTIC_BLOCK_SIZE
>> +""""""""""""""""""""""""
>> +
>> +For compute shaders, this semantic indicates the maximum dimensions (x, y, z)
>> +of a block in threads.
>> +
>> +
>> +TGSI_SEMANTIC_THREAD_ID
>> +"""""""""""""""""""""""
>> +
>> +For compute shaders, this semantic indicates the id of the current thread.
>> +
>> +
>>  Declaration Interpolate
>>  ^^^^^^^^^^^^^^^^^^^^^^^
>>
>> --
>> 2.9.3
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev