[Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

[Emil Velikov]

On 12 September 2016 at 14:51, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Mon, Sep 12, 2016 at 8:37 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> A earlier sync with the Khronos headers added _extension_ prototype
>> guards to all the GLES2/3/31/32 core entry points. Effectively breaking
>> all the applications that aim to be portable and do not set the define.
>>
>> The issue has been reported to Khronos (internal bugzilla #14206) and is
>> being worked on. Until updated/fixed headers are released locally fix
>> the issue.
>>
>> The following report is when building weston.
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97773
>>
>> Cc: Armin Krezović <krezovic.armin at gmail.com>
>> Cc: Emmanuel Gil Peyrot <emmanuel.peyrot at collabora.com>
>> Cc: Pekka Paalanen <ppaalanen at gmail.com>
>> Fixes: 6a5504de2fb ("Update Khronos-supplied headers to r33100")
>> Cc: Ilia Mirkin <imirkin at alum.mit.edu>
>> Cc: Dave Airlie <airlied at redhat.com>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>
> Seems perfectly reasonable to me. IIRC I proposed something like this
> when the issue was first brought up. So this gets my
>
> Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>
Reusing the EXT guard might not be the wise idea but I agree. Some
form of guard/check ought to be present.

> Separately (i.e. doesn't have to be done in this change), now that the
> patches against KHR headers are growing (the apple thing, now this),
> perhaps we might consider keeping a diff checked into the tree so that
> it can be easily applied by the next poor sap who imports updated
> versions.
>
Keeping diff/patches in git always felt like a hack, imho. Plus
most/all(?) distros rely on the Mesa headers, so I'm not sure how that
is going to work.
Note: some distros have strict policy that building/installing
packages must not require internet connection (for fetching Khronos
headers and/or others).

Fwiw, I'm trying to get things rolling with Khronos and upstreaming
(almost?) everything yet it might take some time :-\

Thanks
Emil