[Mesa-dev] [PATCH 1/2] i965: check for GL_TEXTURE_EXTERNAL_OES at miptree_create_for_teximage

Alejandro Piñeiro apinheiro at igalia.com
Mon Sep 12 14:53:37 UTC 2016


I forgot to CC Jason, that made the review of the original commit.

Sorry for the noise.

On 11/09/16 00:07, Alejandro Piñeiro wrote:
> Forgotten on commit "i965: Fix calculation of the image height at start level".
> 
> Thanks to Ilia Mirkin for point it.
> 
> Fixes the following regressions on Haswell and Broadwell:
> ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestSimpleUnassociated (crash back to pass)
> ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestSimple (crash back to fail)
> ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestVertexShader (crash back to fail)
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=97761
> ---
>  src/mesa/drivers/dri/i965/intel_tex_image.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c b/src/mesa/drivers/dri/i965/intel_tex_image.c
> index 65962eb..a012927 100644
> --- a/src/mesa/drivers/dri/i965/intel_tex_image.c
> +++ b/src/mesa/drivers/dri/i965/intel_tex_image.c
> @@ -51,6 +51,7 @@ intel_miptree_create_for_teximage(struct brw_context *brw,
>     case GL_TEXTURE_2D_MULTISAMPLE:
>     case GL_TEXTURE_2D_MULTISAMPLE_ARRAY:
>     case GL_TEXTURE_RECTANGLE:
> +   case GL_TEXTURE_EXTERNAL_OES:
>        assert(intelImage->base.Base.Level == 0);
>        break;
>     case GL_TEXTURE_3D:
> 

-- 
Alejandro Piñeiro <apinheiro at igalia.com>


More information about the mesa-dev mailing list