[Mesa-dev] [PATCH] Remove GL_GLEXT_PROTOTYPES guards from non-ext headers.

Ilia Mirkin imirkin at alum.mit.edu
Mon Sep 12 16:02:22 UTC 2016


On Mon, Sep 12, 2016 at 11:55 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 12 September 2016 at 15:35, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> On Mon, Sep 12, 2016 at 10:10 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>>> Keeping diff/patches in git always felt like a hack, imho. Plus
>>> most/all(?) distros rely on the Mesa headers, so I'm not sure how that
>>> is going to work.
>>
>> The alternatives are considerably more painful for just a handful of
>> files with a small number of diffs. This would be as a tool for
>> developers like us who update the mesa versions by importing new KHR
>> versions, which will not have our local changes applied. The patch
>> would not be used as part of the build process or anything else.
>>
> The goal being to have the patches alongside the patched headers.
> This way one can use them as reference ? Sure sounds great imho.

Exactly. So that when I download new KHR headers, I just apply the
patch to them (and hope it applies), and if not, look at what was
being done and try to repeat the process. Then I regenerate the patch
against the (new) originals and check the whole thing in.

> Fwiw it may be that the EGL diff gets sorted sooner than expected /me
> crosses fingers.

OK. Well, your call. I'm definitely going to do it next time I update
headers (which will hopefully not be soon, given how much trouble it's
caused this time around).

  -ilia


More information about the mesa-dev mailing list