[Mesa-dev] [PATCH] HUD: Add support for block I/O, network I/O and lmsensor stats

Emil Velikov emil.l.velikov at gmail.com
Tue Sep 13 11:42:07 UTC 2016


Hi Steven,

On 12 September 2016 at 19:33, Steven Toth <stoth at kernellabs.com> wrote:
> Three new features:
> 1. Disk/block I/O device read/write stats MB/ps.
> 2. Network Interface RX/TX transfer statistics as a percentage
>    of the overall NIC speed.
> 3. lmsensor power, voltage and temperature sensors.
>
I'm not sure if these should be in the driver itself. In practise
these do not have direct (co-)relation to the performance and/or
experience thus they may be better suited in separate project(s).

That said, if people prefer to have this in mesa let's have it as a
configure toggle. This way people can opt for/against
--enable-gallium-extra-hud, default disabled.

By doing so (the non-unix build don't use autoconf), you'll get
Brian's request by default ;-).

Feel free to improve on the configure toggle name(s).

> @@ -871,6 +872,17 @@ AC_ARG_ENABLE([dri],
>      [enable_dri="$enableval"],
>      [enable_dri=yes])
>
> +#PKG_CHECK_MODULES([LIBSENSORS], [libsensors >= $LIBSENSORS_REQUIRED], [enable_lmsensors=yes], [enable_lmsensors=no])

Yay libsensors/lmsensors does not have a .pc file :-) Please add a
comment - be that XXX/TODO/NOTE or alike.

As a fall-back, set the LIBSENSORS_{CFLAGS,LIBS} here and use both of
those throughout.

Thanks
Emil


More information about the mesa-dev mailing list