[Mesa-dev] [PATCH 13/14] egl: Track EGL_KHR_debug state when going through EGL API calls

[Emil Velikov]

On 12 September 2016 at 23:19, Adam Jackson <ajax at redhat.com> wrote:

> +static EGLBoolean
> +_eglSetFuncName(const char *funcName, _EGLDisplay *disp, EGLenum objectType, _EGLResource *object)
> +{

> +         if (disp != NULL) {
> +            thr->CurrentObjectLabel = disp->Label;
> +         }
> +      } else {
> +         /*
> +          * Everything else will either be NULL or a valid _EGLResource
> +          * pointer.
> +          */
> +         if (object != NULL) {
First thought was object/disp can never be NULL, only to remember that
input validation happens at a later stage. Oh well :-]

Going through table 13.2 and the below there are some discrepancies.
AFAICT some of those can be seen as spec bugs (B), while others seem
to be missing (M)
 - thread - eglBindAPI (M)
 - display - eglGetCurrentDisplay (B)
 - context - eglQueryAPI (M), eglGetCurrentContext (B)
 - surface - eglSwapInterval (B), eglGetCurrentSurface(B)
 - image - ok
 - sync - ok


-Emil