[Mesa-dev] [PATCH 00/14] EGL_KHR_debug v3

Emil Velikov emil.l.velikov at gmail.com
Tue Sep 13 16:30:12 UTC 2016


On 12 September 2016 at 23:19, Adam Jackson <ajax at redhat.com> wrote:
> This gets us to basically the same end state as before, but I've
> rearranged the sequence of changes to be a little easier to review and
> not introduce broken intermediate states.
>
> 01 updates eglext.h to the very latest. 02 is a bugfix for leaking images
> and syncs at eglTerminate, pointed out in review; technically it's an
> independent change. 04 through 11 factor out common code paths so that
> the eventual _EGL_FUNC_START macro can set the current function string
> correctly. 13 wires up the internals of debug state tracking, and 14
> adds the user-facing API.
>
Thanks for squashing and polishing the series, Adam !

Afaict there's a couple of bugfixes squashed with the refactoring (as
mentioned in 09) patches. I don't feel strongly about splitting them
out unless you/others do.

Patches 13 + 14 have a few bugs alongside the coding style issues.
Everything else (1-12 incl.) is
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks
Emil


More information about the mesa-dev mailing list