[Mesa-dev] [PATCH] st/va: also honors interlaced preference when providing a video format

[Andy Furniss]

Leo Liu wrote:
> Hi Andy,
>
> On 09/13/2016 06:22 AM, Andy Furniss wrote:
>> Zhang, Boyuan wrote:
>>> Hi Leo, Christian and Julien,
>>>
>>> I tested the patch with Vaapi Encoding and Transcoding, it seems
>>> working fine. We are using "VAAPI_DISABLE_INTERLACE" env, so
>>> interlaced is always disabled.
>>
>> Though I notice it will break screen recording scripts for existing
>> users who previously didn't need the env set but will after this.
>>
>> Totally untested/thought through, but maybe the env should default to on?
>
> Agree, can you come up a patch for that?

OK, but maybe I should test a bit first to see if anything regresses.

Unfortunately I today, by chance found an issue with mpv.

With VAAPI_DISABLE_INTERLACE=1 which it needs for

mpv --vo-vaapi all is apparently OK when playing say a 25fps vid,
but I've found that if I push the framerate to refresh rate and
do something that draws OSD than image is corrupted, possible many
VM faults logged followed by a segfault in u_copy_yv12_img_to_nv12_surf
this happens with or without the uv swap patch below. I will file a bug
after more investigation. Bisecting mesa goes back to the commit that
introduced  VAAPI_DISABLE_INTERLACE.

> Also any outstanding patches for VA-API encode from you was reviewed,
> but not committed?
> if any, sent to me, I can push them.

There's only

https://lists.freedesktop.org/archives/mesa-dev/2016-July/124695.html

for the uv swap issue.

Not my issue as such, but did anyone notice this from Mark Thompson, who
does vaapi for libav/ffmpeg?

I notice he didn't keep the CCs so maybe it got missed.

https://lists.freedesktop.org/archives/mesa-dev/2016-September/128076.html