[Mesa-dev] [PATCH 1/2] isl/state: Don't set QPitch for GEN4_3D surfaces

[Chad Versace]

On Thu 08 Sep 2016, Jason Ekstrand wrote:
> ---
>  src/intel/isl/isl_surface_state.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c
> index 979e140..f8ea122 100644
> --- a/src/intel/isl/isl_surface_state.c
> +++ b/src/intel/isl/isl_surface_state.c
> @@ -172,7 +172,6 @@ get_qpitch(const struct isl_surf *surf)
>     default:
>        unreachable("Bad isl_surf_dim");
>     case ISL_DIM_LAYOUT_GEN4_2D:
> -   case ISL_DIM_LAYOUT_GEN4_3D:
>        if (GEN_GEN >= 9) {
>           return isl_surf_get_array_pitch_el_rows(surf);
>        } else {
> @@ -199,6 +198,22 @@ get_qpitch(const struct isl_surf *surf)
>         *    slices.
>         */
>        return isl_surf_get_array_pitch_el(surf);
> +   case ISL_DIM_LAYOUT_GEN4_3D:
> +      /* QPitch doesn't make sense for ISL_DIM_LAYOUT_GEN4_3D since it uses a
> +       * different pitch at each LOD.  Also, the QPitch field is ignored for
> +       * these surfaces.

Yep.
Reviewed-by: Chad Versace <chadversary at chromium.org>