[Mesa-dev] [PATCH mesa] glsl: grammar fix

Eric Engestrom eric.engestrom at imgtec.com
Wed Sep 14 14:28:28 UTC 2016


From: Eero Tamminen <eero.t.tamminen at intel.com>

Signed-off-by: Eero Tamminen <eero.t.tamminen at intel.com>
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>
---

Eero, this is the format a patch should have when sent to mesa-dev.
You can find more info on our website [1], but the gist of it is:
- Use `git send-email`, don't attach patches to emails
- Describe the change done by the patch. This consists of:
  - Title: starting with a prefix describing what it components affects,
    and followed by a short sentence explaining the change.
  - Body: if the change is non-trivial, explain it.
- Signature, in the form "Signed-off-by: Name <email>". This isn't required,
  but recommended. It indicates who authored the change (can be more than
  one person, unlike the git author).

Additionally, anything after the first `---` doesn't appear in the commit
message, which is useful for email-only comments like this one.

Cheers,
  Eric

[1] http://www.mesa3d.org/devinfo.html#submitting

---
 src/compiler/glsl/linker.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/compiler/glsl/linker.cpp b/src/compiler/glsl/linker.cpp
index 4440c03..f3eece2 100644
--- a/src/compiler/glsl/linker.cpp
+++ b/src/compiler/glsl/linker.cpp
@@ -750,8 +750,8 @@ validate_vertex_shader_executable(struct gl_shader_program *prog,
       if (!find.variable_found()) {
         if (prog->IsES) {
           linker_warning(prog,
-                         "vertex shader does not write to `gl_Position'."
-                         "It's value is undefined. \n");
+                         "vertex shader does not write to `gl_Position'. "
+                         "Its value is undefined. \n");
         } else {
           linker_error(prog,
                        "vertex shader does not write to `gl_Position'. \n");
-- 
Cheers,
  Eric



More information about the mesa-dev mailing list