[Mesa-dev] [PATCH v2 3/7] intel/isl: Add support for 1-D compressed textures

[Nanley Chery]

On Mon, Sep 12, 2016 at 05:58:20PM -0700, Jason Ekstrand wrote:
> Compressed 1-D textures are a well-defined thing in both GL and Vulkan.
> ---
>  src/intel/isl/isl.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index a75fddf..185984d 100644
> --- a/src/intel/isl/isl.c
> +++ b/src/intel/isl/isl.c
> @@ -518,7 +518,6 @@ isl_calc_phys_level0_extent_sa(const struct isl_device *dev,
>        assert(info->height == 1);
>        assert(info->depth == 1);
>        assert(info->samples == 1);
> -      assert(!isl_format_is_compressed(info->format));
>  
>        switch (dim_layout) {
>        case ISL_DIM_LAYOUT_GEN4_3D:
> @@ -527,8 +526,8 @@ isl_calc_phys_level0_extent_sa(const struct isl_device *dev,
>        case ISL_DIM_LAYOUT_GEN9_1D:
>        case ISL_DIM_LAYOUT_GEN4_2D:
>           *phys_level0_sa = (struct isl_extent4d) {
> -            .w = info->width,
> -            .h = 1,
> +            .w = isl_align_npot(info->width, fmtl->bw),
> +            .h = fmtl->bh,
>              .d = 1,
>              .a = info->array_len,

Mustn't the height assertion in get_image_offset_sa_gen9_1d() be
removed with this change?

>           };
> -- 
> 2.5.0.400.gff86faf
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev