[Mesa-dev] [PATCH] mesa: Expose RESET_NOTIFICATION_STRATEGY with KHR_robustness.

[Ilia Mirkin]

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

On Wed, Sep 14, 2016 at 8:47 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> This is supposed to be exposed with the GL_KHR_robustness extension,
> which we support on ES 2.0 and later.  On desktop GL, it's also exposed
> by GL_ARB_robustness, which is supported by all drivers ("dummy_true").
> so we also allow desktop GL.
>
> Fixes:
> - ES32-CTS.robust.robustness.noResetNotification
> - ES32-CTS.robust.robustness.loseContextOnReset
>
> Cc: mesa-stable at lists.freedesktop.org
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/main/get.c              | 7 +++++++
>  src/mesa/main/get_hash_params.py | 6 +++---
>  2 files changed, 10 insertions(+), 3 deletions(-)
>
> diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
> index 3cabb2b..e7ebc7f 100644
> --- a/src/mesa/main/get.c
> +++ b/src/mesa/main/get.c
> @@ -423,6 +423,13 @@ static const int extra_ES32[] = {
>     EXTRA_END
>  };
>
> +static const int extra_KHR_robustness_or_GL[] = {
> +   EXT(KHR_robustness),
> +   EXTRA_API_GL,
> +   EXTRA_API_GL_CORE,
> +   EXTRA_END
> +};
> +
>  EXTRA_EXT(ARB_texture_cube_map);
>  EXTRA_EXT(EXT_texture_array);
>  EXTRA_EXT(NV_fog_distance);
> diff --git a/src/mesa/main/get_hash_params.py b/src/mesa/main/get_hash_params.py
> index 4b86697..1f63dc3 100644
> --- a/src/mesa/main/get_hash_params.py
> +++ b/src/mesa/main/get_hash_params.py
> @@ -341,6 +341,9 @@ descriptor=[
>
>  # GL_KHR_blend_equation_advanced_coherent
>    [ "BLEND_ADVANCED_COHERENT_KHR", "CONTEXT_BOOL(Color.BlendCoherent), extra_KHR_blend_equation_advanced_coherent" ],
> +
> +# GL_ARB_robustness / GL_KHR_robustness
> +  [ "RESET_NOTIFICATION_STRATEGY_ARB", "CONTEXT_ENUM(Const.ResetStrategy), extra_KHR_robustness_or_GL" ],
>  ]},
>
>  # GLES3 is not a typo.
> @@ -901,9 +904,6 @@ descriptor=[
>  # GL 3.2
>    [ "CONTEXT_PROFILE_MASK", "CONTEXT_INT(Const.ProfileMask), extra_version_32" ],
>
> -# GL_ARB_robustness
> -  [ "RESET_NOTIFICATION_STRATEGY_ARB", "CONTEXT_ENUM(Const.ResetStrategy), NO_EXTRA" ],
> -
>  # GL_ARB_timer_query
>    [ "TIMESTAMP", "LOC_CUSTOM, TYPE_INT64, 0, extra_ARB_timer_query" ],
>
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev