[Mesa-dev] [PATCH] Revert "st/vdpau: use linear layout for output surfaces"

[Dave Airlie]

On 15 September 2016 at 17:43, Christian König <deathsimple at vodafone.de> wrote:
> Am 15.09.2016 um 06:00 schrieb Ilia Mirkin:
>>
>> On Wed, Sep 14, 2016 at 11:58 PM, Dave Airlie <airlied at gmail.com> wrote:
>>>
>>> From: Dave Airlie <airlied at redhat.com>
>>>
>>> This reverts commit d180de35320eafa3df3d76f0e82b332656530126.
>>>
>>> This is a radeon specific hack that causes problems on nouveau
>>> when combined with the SHARED flag later. If radeonsi needs a fix
>>> for this, please fix it in the driver.
>
>
> Actually it isn't radeon specific. Using linear surfaces for this makes
> sense because tilling isn't beneficial and the surfaces can potentially be
> shared with other GPUs using the VDPAU OpenGL interop.

Who says tiling isn't beneficial though? Maybe on other GPUs tiling might be, it
still seems like a radeon centric view to me.

I don't think the API should be dictating that, possibly the backend should get
more info to decide if it wants to use LINEAR.

it would be good if you guys can smoketest this at least, esp if we cc
it for stable.

Dave.