[Mesa-dev] [PATCH 01/10] i965: use nir_lower_indirect_derefs() for GLSL Gen7+

[Kenneth Graunke]

On Friday, September 16, 2016 11:10:01 AM PDT Timothy Arceri wrote:
> On Thu, 2016-09-15 at 17:55 -0700, Jason Ekstrand wrote:
> > > On Sep 15, 2016 4:31 PM, "Timothy Arceri" <timothy.arceri at collabora.com> wrote:
> > > On Thu, 2016-09-15 at 12:34 -0700, Jason Ekstrand wrote:
> > > > > On Sep 15, 2016 12:05 AM, "Timothy Arceri" <timothy.arceri at collabora.com> wrote:
> > > > > +   if (compiler->devinfo->gen > 6) {
> > 
> > > > I think you want "> 7" here
> > 
> > >
> > 
> > > > It can be used with gen 7 and up. I could change it to >= 7 if that
> is
> > 
> > > easier to parse but I think > 6 is functionally correct.
> > > Hunh? You use GLSL for gen7. Why are we duplicating? Also, why can't
> this be used on sandy bridge and earlier?
> 
> GLSL IR is used for the non scalar stages on gen7. See my answers to
> Connors questions:
> https://lists.freedesktop.org/archives/mesa-dev/2016-September/129108.html

If you're trying to use GLSL IR lowering for vector stages and NIR
lowering for scalar stages, why not just use:

   compiler->scalar_stage[nir->stage]

rather than generation checks?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160915/0150e810/attachment.sig>