[Mesa-dev] [PATCH] gk110/ir: fix wrong emission of OP_NOT

Ilia Mirkin imirkin at alum.mit.edu
Sun Sep 18 13:40:37 UTC 2016


Wow! I wonder how that happened... and went undetected for so long.
Probably a copy-paste from emitForm_21 or something.

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

On Sun, Sep 18, 2016 at 8:42 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> This should emit src0 instead of src1.
> Found by inspection.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
> index 83ec268..4ad2c30 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
> @@ -780,7 +780,7 @@ CodeEmitterGK110::emitNOT(const Instruction *i)
>        break;
>     case FILE_MEMORY_CONST:
>        code[1] |= 0x4 << 28;
> -      setCAddress14(i->src(1));
> +      setCAddress14(i->src(0));
>        break;
>     default:
>        assert(0);
> --
> 2.8.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list