[Mesa-dev] [PATCH 0/2] Implement lanczos interpolation filter

[Nayan Deshmukh]

Hi Andy,



On Wed, Sep 21, 2016 at 9:30 PM, Andy Furniss <adf.lists at gmail.com> wrote:

> Andy Furniss wrote:
>
>> Andy Furniss wrote:
>>
>>> Andy Furniss wrote:
>>>
>>>> Andy Furniss wrote:
>>>>
>>>> bz2 compressed vid showing the issue -
>>>>>
>>>>> https://drive.google.com/open?id=0BxP5-S1t9VEEUE5sbUFBV20zSms
>>>>>
>>>>
>>>> To be clear this is just the test rez vid I used so you can
>>>> possibly recreate the issue your self.
>>>>
>>>
>>> Hmm, interesting, with bicubic, hqscaling=1 this vid behaves
>>> differently with mplayer compared to mpv, the latter looks like
>>> it's scaling a bit, maybe there's an off by one somewhere in mpv
>>> code.
>>>
>>
>> I don't know if it's the cause, but looking for differences between
>> mplayer and mpv it seems that mpv sets video mixer height so it's
>> divisible by 32 but mplayer doesn't. For this 720p sample it uses 736
>> and mplayer uses 720.
>>
>> vdp_video_mixer_create(1, 1, {11}, 3, {0, 1, 2}, {1280, 736, 0}, -)
>>
>> for output surfaces and render calls it uses 720.
>>
>> So does the bicubic code see/use this 736 somewhere?
>>
>
> To answer my own question - it does.
>
> Putting a printf in vl_bicubic.c create_frag_shader video_height = 736
>
> We intialize the filters with height of video mixer, So that explains the
difference.

I was not able to make any progress with offsets nor the artifacts. Can you
try
testing the lanczos filter by removing this line form create_frag_shader :-

ureg_SUB(shader, ureg_writemask(t_array[1], TGSI_WRITEMASK_XY),
            ureg_src(t_array[1]), half_pixel);

I am not able to replicate the offset issue in my system, though the
artifacts
issue is reproducible for all levels except 2 and 4

Regards,
Nayan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160921/5c93eac5/attachment.html>