[Mesa-dev] [PATCH] anv: Check for VK_WHOLE_SIZE in anv_CmdFillBuffer

[Jason Ekstrand]

On Wed, Sep 21, 2016 at 3:40 PM, Nicolas Koch <nioko1337 at gmail.com> wrote:

> Hey Jason, thanks for reviewing.
>
> This is my first mesa contribution, and I'm not really familiar with
> the mailing-list workflow.
>

Thanks for the contribution and welcome to mesa!


> Is there anything else I need to do to get this merged? Or will
> someone just do it in the near future?
>

Other than bugging one of the reviewers to push it for you, no.  Seeing as
you've already done that... I'll push it some time today. :-)


> On Tue, Sep 20, 2016 at 7:09 PM, Jason Ekstrand <jason at jlekstrand.net>
> wrote:
> > Seems reasonable
> >
> > Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
> >
> > This reminds me that we really need to convert CmdFillBuffer over to
> using
> > blorp...
> >
> >
> > On Sep 20, 2016 6:37 PM, "Nicolas Koch" <nioko1337 at gmail.com> wrote:
> >>
> >> Vulkan spec:
> >> Size is the number of bytes to fill, and must be either a multiple of 4,
> >> or VK_WHOLE_SIZE to fill the range from offset to the end of the buffer.
> >> If VK_WHOLE_SIZE is used and the remaining size of the buffer is not a
> >> multiple of 4, then the nearest smaller multiple is used.
> >> ---
> >>  src/intel/vulkan/anv_meta_clear.c | 6 ++++++
> >>  1 file changed, 6 insertions(+)
> >>
> >> diff --git a/src/intel/vulkan/anv_meta_clear.c
> >> b/src/intel/vulkan/anv_meta_clear.c
> >> index ed4d1db..fd0797f 100644
> >> --- a/src/intel/vulkan/anv_meta_clear.c
> >> +++ b/src/intel/vulkan/anv_meta_clear.c
> >> @@ -1012,6 +1012,12 @@ void anv_CmdFillBuffer(
> >>
> >>     meta_clear_begin(&saved_state, cmd_buffer);
> >>
> >> +   if (fillSize == VK_WHOLE_SIZE) {
> >> +      fillSize = dst_buffer->size - dstOffset;
> >> +      /* Make sure fillSize is a multiple of 4 */
> >> +      fillSize -= fillSize & 3;
> >> +   }
> >> +
> >>     VkFormat format;
> >>     int bs;
> >>     if ((fillSize & 15) == 0 && (dstOffset & 15) == 0) {
> >> --
> >> 2.10.0
> >>
> >> _______________________________________________
> >> mesa-dev mailing list
> >> mesa-dev at lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160921/94474f34/attachment-0001.html>