[Mesa-dev] [PATCH 1/2] gbm/dri2: propagate errors when creating a DMA-BUF fd

[Emil Velikov]

Hi Nicholas,

On 8 September 2016 at 20:55, Nicholas Bishop <nbishop at neverware.com> wrote:
> Changed dri2_query_image to check the return value of
> resource_get_handle and return GL_FALSE if an error occurs. Similarly
> changed gbm_dri_bo_get_fd to check the return value of queryImage and
> return -1 (an invalid file descriptor) if an error occurs.
>
> Updated the comment for gbm_bo_get_fd to say that -1 is returned if
> an error occurs.
>
> For reference this is an example callstack that should propagate the
> error back to the user:
>
>     i915_drm_buffer_get_handle
>     i915_texture_get_handle
>     u_resource_get_handle_vtbl
>     dri2_query_image
>     gbm_dri_bo_get_fd
>     gbm_bo_get_fd
>
> Signed-off-by: Nicholas Bishop <nbishop at neverware.com>
> ---
>  src/gallium/state_trackers/dri/dri2.c | 11 +++++++----
>  src/gbm/backends/dri/gbm_dri.c        |  8 +++++---
>  src/gbm/main/gbm.c                    |  3 ++-
Thanks for the patches. I've split this into two (loader src/gbm and
"driver" src/gallium...) fixes, tagged for stable, applied some coding
style polish and pushed the series to master.

-Emil