[Mesa-dev] [PATCH mesa 1/4] nir/spirv: add some error checking to open()

Eric Engestrom eric at engestrom.ch
Sun Sep 25 15:49:50 UTC 2016


CovID: 1373369
Signed-off-by: Eric Engestrom <eric at engestrom.ch>
---
 src/compiler/spirv/spirv2nir.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/compiler/spirv/spirv2nir.c b/src/compiler/spirv/spirv2nir.c
index c837186..d151c2c 100644
--- a/src/compiler/spirv/spirv2nir.c
+++ b/src/compiler/spirv/spirv2nir.c
@@ -37,10 +37,17 @@
 #include <sys/types.h>
 #include <fcntl.h>
 #include <unistd.h>
+#include <stdio.h>
 
 int main(int argc, char **argv)
 {
    int fd = open(argv[1], O_RDONLY);
+   if (fd < 0)
+   {
+      fprintf(stderr, "Failed to open %s\n", argv[1]);
+      return 1;
+   }
+
    off_t len = lseek(fd, 0, SEEK_END);
 
    assert(len % 4 == 0);
@@ -52,4 +59,6 @@ int main(int argc, char **argv)
    nir_function *func = spirv_to_nir(map, word_count, NULL, 0,
                                      MESA_SHADER_FRAGMENT, "main", NULL);
    nir_print_shader(func->shader, stderr);
+
+   return 0;
 }
-- 
Cheers,
  Eric



More information about the mesa-dev mailing list