[Mesa-dev] [PATCH 71/88] i965: create populate key functions for tcs and tes

[Kenneth Graunke]

On Saturday, September 24, 2016 3:25:52 PM PDT Timothy Arceri wrote:
> These will be used by the on disk shader cache.
> ---
>  src/mesa/drivers/dri/i965/brw_program.h      | 10 ++--
>  src/mesa/drivers/dri/i965/brw_state_upload.c | 18 +------
>  src/mesa/drivers/dri/i965/brw_tcs.c          | 70 +++++++++++++++++-----------
>  src/mesa/drivers/dri/i965/brw_tes.c          | 58 +++++++++++++++--------
>  4 files changed, 88 insertions(+), 68 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c b/src/mesa/drivers/dri/i965/brw_state_upload.c
> index e88ca0e..b86a896 100644
> --- a/src/mesa/drivers/dri/i965/brw_state_upload.c
> +++ b/src/mesa/drivers/dri/i965/brw_state_upload.c
> @@ -682,22 +682,8 @@ static inline void
>  brw_upload_tess_programs(struct brw_context *brw)
>  {
>     if (brw->tess_eval_program) {
> -      uint64_t per_vertex_slots = brw->tess_eval_program->Base.InputsRead;
> -      uint32_t per_patch_slots =
> -         brw->tess_eval_program->Base.PatchInputsRead;
> -
> -      /* The TCS may have additional outputs which aren't read by the
> -       * TES (possibly for cross-thread communication).  These need to
> -       * be stored in the Patch URB Entry as well.
> -       */
> -      if (brw->tess_ctrl_program) {
> -         per_vertex_slots |= brw->tess_ctrl_program->Base.OutputsWritten;
> -         per_patch_slots |=
> -            brw->tess_ctrl_program->Base.PatchOutputsWritten;
> -      }

Kind of sad to see this logic replicated in both key functions,
but oh well.  This patch is:

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160925/98bacf0a/attachment.sig>