[Mesa-dev] [PATCH mesa 4/4] nir/spirv: add spirv2nir binary to .gitignore

Eric Engestrom eric.engestrom at imgtec.com
Mon Sep 26 10:00:22 UTC 2016


On Sun, Sep 25, 2016 at 10:49:29AM -0700, Jason Ekstrand wrote:
> I hope you realize that this is the only truly useful change in the series.
> :-). Still, no reason why our silly little helpers shouldn't be correct.

Yeah, I know :P
I got the Coverity report like everyone and thought we might as well
print real error messages, esp. since asserts are gone in release builds
(but who would use spirv2nir in a release build? ^^)

> Series is
> 
> Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

Thanks! Can you push it for me?

Cheers,
  Eric

> 
> On Sep 25, 2016 6:50 PM, "Eric Engestrom" <eric at engestrom.ch> wrote:
> 
> > Signed-off-by: Eric Engestrom <eric at engestrom.ch>
> > ---
> >  src/compiler/.gitignore | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/src/compiler/.gitignore b/src/compiler/.gitignore
> > index c0e6299..c4f17be 100644
> > --- a/src/compiler/.gitignore
> > +++ b/src/compiler/.gitignore
> > @@ -3,3 +3,4 @@ subtest-cr
> >  subtest-cr-lf
> >  subtest-lf
> >  subtest-lf-cr
> > +spirv2nir
> > --
> > Cheers,
> >   Eric
> >
> >


More information about the mesa-dev mailing list