[Mesa-dev] [RFC] egl: stop claiming support for pbuffer + msaa (RFC)

[Marek Olšák]

Sounds good to me. I think only legacy applications would use
pbuffers. There is no reason to use pbuffers on anything that has
GL_ARB_framebuffer_object (pbuffers were use to do render-to-texture
when FBOs didn't exist).

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Mon, Sep 26, 2016 at 9:41 AM, Tapani Pälli <tapani.palli at intel.com> wrote:
> This fixes a crash in egl-create-msaa-pbuffer-surface Piglit test
> and same crash in many dEQP EGL tests.
>
> I also found that some Qt example did a workaround because of this
> crash: https://bugreports.qt.io/browse/QTBUG-47509
>
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> ---
>
> This is RFC as I'm not sure if we are supposed to support this. I tried
> to verify overall pbuffer situation with some mesa-demos using pbuffer
> but those are not working for me at all with or without my patch.
>
>  src/egl/main/eglconfig.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/src/egl/main/eglconfig.c b/src/egl/main/eglconfig.c
> index 6161d26..20cf9d4 100644
> --- a/src/egl/main/eglconfig.c
> +++ b/src/egl/main/eglconfig.c
> @@ -407,6 +407,11 @@ _eglValidateConfig(const _EGLConfig *conf, EGLBoolean for_matching)
>        return EGL_FALSE;
>     }
>
> +   /* pbuffer with MSAA not supported */
> +   if (conf->SurfaceType & EGL_PBUFFER_BIT && conf->Samples) {
> +      return EGL_FALSE;
> +   }
> +
>     if (!(conf->SurfaceType & EGL_WINDOW_BIT)) {
>        if (conf->NativeVisualID != 0 || conf->NativeVisualType != EGL_NONE)
>           valid = EGL_FALSE;
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev