[Mesa-dev] [PATCH 0/6] i965/sync: Fix dEQP-EGL.functional.gles2.multithread.*

Chad Versace chadversary at chromium.org
Wed Sep 28 06:51:18 UTC 2016


Test results of dEQP-EGL.functional.gles2.multithread.* on Skylake,
using deqp-egl directly (no Piglit):

  * Before:
        Bajillions of failures and randomly occuring crashes. The
        testrun died on me on 10/10 tries.

  * After:
        Passed:        1253/1254 (99.9%)
        Failed:        1/1254 (0.1%)

I did this because I'm prepping for EGL_ANDROID_native_fence_sync. And
there's little point in implementing a new sync feature if the current
sync is this broken.

Bundles along with the fixes are some cleanups too.

Patches live at http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=review/brw-sync-v01

Chad Versace (6):
  i965/sync: Fix uninitalized usage and leak of mutex
  i965/sync: Stop cacheing fence's signal status
  i965/sync: Fold brw_fence_has_completed() into caller
  i965/sync: Replace 'intel' prefix with 'brw'
  i965/sync: Rename intel_syncobj.c -> brw_sync.c
  i965/sync: Rename awkward variable

 src/mesa/drivers/dri/i965/Makefile.sources         |   2 +-
 src/mesa/drivers/dri/i965/brw_context.c            |   2 +-
 src/mesa/drivers/dri/i965/brw_context.h            |   4 +-
 .../dri/i965/{intel_syncobj.c => brw_sync.c}       | 140 +++++++++------------
 4 files changed, 61 insertions(+), 87 deletions(-)
 rename src/mesa/drivers/dri/i965/{intel_syncobj.c => brw_sync.c} (64%)

-- 
2.10.0



More information about the mesa-dev mailing list