[Mesa-dev] [PATCH 2/2] gallium/radeon: use smaller buffers for query results

Marek Olšák maraeo at gmail.com
Wed Sep 28 13:51:45 UTC 2016


For the series:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Tue, Sep 27, 2016 at 4:56 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>
> Most of the time, even the 512 bytes that we now get is more than sufficient
> (pipeline stats queries are the largest at 184 bytes per shot).
> ---
>  src/gallium/drivers/radeon/r600_query.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c
> index 2c3d530..0dce1c9 100644
> --- a/src/gallium/drivers/radeon/r600_query.c
> +++ b/src/gallium/drivers/radeon/r600_query.c
> @@ -311,21 +311,21 @@ void r600_query_hw_destroy(struct r600_common_context *rctx,
>         }
>
>         r600_resource_reference(&query->buffer.buf, NULL);
>         FREE(rquery);
>  }
>
>  static struct r600_resource *r600_new_query_buffer(struct r600_common_context *ctx,
>                                                    struct r600_query_hw *query)
>  {
>         unsigned buf_size = MAX2(query->result_size,
> -                                ctx->screen->info.gart_page_size);
> +                                ctx->screen->info.min_alloc_size);
>
>         /* Queries are normally read by the CPU after
>          * being written by the gpu, hence staging is probably a good
>          * usage pattern.
>          */
>         struct r600_resource *buf = (struct r600_resource*)
>                 pipe_buffer_create(ctx->b.screen, PIPE_BIND_CUSTOM,
>                                    PIPE_USAGE_STAGING, buf_size);
>         if (!buf)
>                 return NULL;
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list