[Mesa-dev] [PATCH] anv/gen7_pipeline: Use MSDISPMODE_PERSAMPLE for non-multisampled fbo

[Anuj Phogat]

On Wed, Sep 21, 2016 at 12:49 PM, Anuj Phogat <anuj.phogat at gmail.com> wrote:
> On Wed, Sep 21, 2016 at 11:49 AM, Jason Ekstrand <jason at jlekstrand.net> wrote:
>> This seems odd... When can it even happen that we have persample_dispatch
>> set in wm_surface_state and have only one sample?  Does this fix a test
>> case?
>>
> No, It just fixes a simulator warning. It's recommended in graphics spec
> for gen7. Also look at gen7_wm_state.c.
>
Jason, do you still have concerns about this patch?
>>
>> On Sep 21, 2016 9:14 PM, "Anuj Phogat" <anuj.phogat at gmail.com> wrote:
>>>
>>> Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
>>> ---
>>>  src/intel/vulkan/gen7_pipeline.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/src/intel/vulkan/gen7_pipeline.c
>>> b/src/intel/vulkan/gen7_pipeline.c
>>> index 878308b..5150ef9 100644
>>> --- a/src/intel/vulkan/gen7_pipeline.c
>>> +++ b/src/intel/vulkan/gen7_pipeline.c
>>> @@ -267,7 +267,8 @@ genX(graphics_pipeline_create)(
>>>
>>>           wm.MultisampleRasterizationMode        = samples > 1 ?
>>>                                                    MSRASTMODE_ON_PATTERN :
>>> MSRASTMODE_OFF_PIXEL;
>>> -         wm.MultisampleDispatchMode             =
>>> wm_prog_data->persample_dispatch ?
>>> +         wm.MultisampleDispatchMode             = ((samples == 1) ||
>>> +                                                   (samples > 1 &&
>>> wm_prog_data->persample_dispatch)) ?
>>>                                                    MSDISPMODE_PERSAMPLE :
>>> MSDISPMODE_PERPIXEL;
>>>        }
>>>     }
>>> --
>>> 2.5.5
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev