[Mesa-dev] Mesa (master): gallium/radeon: zero all query buffers

[Michel Dänzer]

On 29/09/16 06:24 PM, Nicolai =?UNKNOWN?Q?H=C3=A4hnle?= wrote:
> Module: Mesa
> Branch: master
> Commit: 2c9d546402a4e3fb55bc3a01a5843dfca82b4a6a
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2c9d546402a4e3fb55bc3a01a5843dfca82b4a6a
> 
> Author: Nicolai Hähnle <nicolai.haehnle at amd.com>
> Date:   Thu Sep 15 15:58:36 2016 +0200
> 
> gallium/radeon: zero all query buffers

This change caused the piglit test spec at amd_performance_monitor@measure
to crash for me, see backtrace below. Looks like it may not be the fault
of this change per se but that the r600_perfcounter code needs to be
updated to support the prepare_buffer op?

Thread 1 "amd_performance" received signal SIGSEGV, Segmentation fault.
0x0000000000000000 in ?? ()
(gdb) bt
#0  0x0000000000000000 in ?? ()
#1  0x00007ffff0eba13c in r600_new_query_buffer (query=0x86ee00, query at entry=0x0, ctx=0x62e760, ctx at entry=0x0) at ../../../../../src/gallium/drivers/radeon/r600_query.c:341
#2  r600_query_hw_init (rctx=rctx at entry=0x62e760, query=query at entry=0x86ee00) at ../../../../../src/gallium/drivers/radeon/r600_query.c:415
#3  0x00007ffff0eb440c in r600_create_batch_query (ctx=0x62e760, num_queries=<optimized out>, query_types=<optimized out>) at ../../../../../src/gallium/drivers/radeon/r600_perfcounter.c:411
#4  0x00007ffff08968cb in init_perf_monitor (m=0x86cf40, ctx=0x798fb0) at ../../../src/mesa/state_tracker/st_cb_perfmon.c:113
#5  st_BeginPerfMonitor (ctx=0x798fb0, m=0x86cf40) at ../../../src/mesa/state_tracker/st_cb_perfmon.c:180
#6  0x00007ffff0788078 in _mesa_BeginPerfMonitorAMD (monitor=<optimized out>) at ../../../src/mesa/main/performance_monitor.c:547
#7  0x00007ffff7a984b0 in stub_glBeginPerfMonitorAMD (monitor=1) at tests/util/piglit-dispatch-gen.c:799
#8  0x00000000004012b8 in test_basic_measurement (group=0) at tests/spec/amd_performance_monitor/measure.c:144
#9  0x0000000000401de2 in piglit_init (argc=1, argv=0x7fffffffe748) at tests/spec/amd_performance_monitor/measure.c:386
#10 0x00007ffff7b39b18 in run_test (gl_fw=0x615c20, argc=1, argv=0x7fffffffe748) at tests/util/piglit-framework-gl/piglit_winsys_framework.c:73
#11 0x00007ffff7b1e667 in piglit_gl_test_run (argc=1, argv=0x7fffffffe748, config=0x7fffffffe610) at tests/util/piglit-framework-gl.c:199
#12 0x0000000000400ff0 in main (argc=1, argv=0x7fffffffe748) at tests/spec/amd_performance_monitor/measure.c:39



-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer