[Mesa-dev] [PATCH 2/3] glx: return GL_FALSE from glx_screen_init where applicable.

Emil Velikov emil.l.velikov at gmail.com
Fri Sep 30 10:01:27 UTC 2016


From: Emil Velikov <emil.velikov at collabora.com>

Return GL_FALSE if we fail to find any fb/visual configs, otherwise we
end up with all sorts of chaos further down the GLX stack.

Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
 src/glx/glxext.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/glx/glxext.c b/src/glx/glxext.c
index 4c03011..869e1a6 100644
--- a/src/glx/glxext.c
+++ b/src/glx/glxext.c
@@ -741,8 +741,11 @@ glx_screen_init(struct glx_screen *psc,
    psc->dpy = priv->dpy;
    psc->display = priv;
 
-   getVisualConfigs(psc, priv, screen);
-   getFBConfigs(psc, priv, screen);
+   if (!getVisualConfigs(psc, priv, screen))
+      return GL_FALSE;
+
+   if (!getFBConfigs(psc, priv, screen))
+      return GL_FALSE;
 
    return GL_TRUE;
 }
-- 
2.9.3



More information about the mesa-dev mailing list