[Mesa-dev] [PATCH] radv: fix order of the guardband register emission.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Sun Apr 2 09:48:24 UTC 2017


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>


On Sun, Apr 2, 2017 at 6:47 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> y is vert, x is horiz.
>
> Noticed in visual inspection compared to radeonsi.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/si_cmd_buffer.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/amd/vulkan/si_cmd_buffer.c b/src/amd/vulkan/si_cmd_buffer.c
> index e847dcf..e176abe 100644
> --- a/src/amd/vulkan/si_cmd_buffer.c
> +++ b/src/amd/vulkan/si_cmd_buffer.c
> @@ -627,10 +627,10 @@ si_write_scissors(struct radeon_winsys_cs *cs, int first,
>         }
>
>         radeon_set_context_reg_seq(cs, R_028BE8_PA_CL_GB_VERT_CLIP_ADJ, 4);
> -       radeon_emit(cs, fui(guardband_x));
> -       radeon_emit(cs, fui(1.0));
>         radeon_emit(cs, fui(guardband_y));
>         radeon_emit(cs, fui(1.0));
> +       radeon_emit(cs, fui(guardband_x));
> +       radeon_emit(cs, fui(1.0));
>  }
>
>  static inline unsigned
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list