[Mesa-dev] [PATCH v2] util/u_atomic: provide 64bit atomics where they're missing

[Mark Janes]

This commit appears to intermittently provoke gpu hangs on 32-bit Intel
systems when running

piglit.shaders.glsl-max-varyings >max_varying_components

Since the behavior is intermittent, I may have identified the wrong
patch.  Please let me know if this patch seems unlikely to affect the
test.

Matt Turner <mattst88 at gmail.com> writes:

> On Thu, Mar 30, 2017 at 3:47 PM, Matt Turner <mattst88 at gmail.com> wrote:
>> On Thu, Mar 30, 2017 at 3:26 PM, Grazvydas Ignotas <notasas at gmail.com>
> wrote:
>>> There are still some distributions trying to support unfortunate people
>>> with old or exotic CPUs that don't have 64bit atomic operations. When
>>> compiling for such a machine, gcc conveniently inserts a library call to
>>> a helper, but it's implementation is missing and we get a linker error.
>>> This allows us to provide our own implementation, which is marked weak
>>> to prefer a better implementation, should one exist.
>>>
>>> v2: changed copyright, some style adjustments
>>>
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93089
>>> Signed-off-by: Grazvydas Ignotas <notasas at gmail.com>
>>> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>>
>> Thanks, I'll commit this.
>>
>>> ---
>>>  no commit access, but request sent:
>>>  https://bugs.freedesktop.org/show_bug.cgi?id=100467
>>
>> Thanks. I commented on the bug and said I approve :)
>
> I modified the patch slightly to print the results of the test with
> AC_MSG_CHECKING/AC_MSG_RESULT and pushed it as commit a6a38a038bd62e.
>
> I'll do some build tests on various architectures. I think I like the idea
> of this going to the stable 17.0 branch.
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev