[Mesa-dev] [PATCH] radeon/video: only support h264 baseline encode

[Christian König]

Am 04.04.2017 um 18:40 schrieb Andy Furniss:
> Well it's a tricky situation with cabac which would be a shame to loose.
Yeah, completely agree.

>
> Currently I guess it's a bit strange advertising main/high - but then
> others do without having mbaff support ....

As noted before mbaff isn't so much of a problem. I mean the stream 
wouldn't be what the application requested, but it would still be 
correctly encoded.

The bigger problem is that we can't convince our firmware team to 
support B-frames.

I've added my manager and going to raise the topic on our next 
multimedia call once more.

Regards,
Christian.

>
> As it stands with cabac on I can make (what I think is) a perfectly
> legal stream with ffmpeg or gstreamer (ignoring current mesa issue).
>
> ... -c:v h264_vaapi -profile:v 77 -bf 0 ...
>
> ... max-bframes=0 ! video/x-h264, profile=main ...
>
>
> Christian König wrote:
>> Am 04.04.2017 um 17:38 schrieb boyuan.zhang at amd.com:
>>> From: Boyuan Zhang <boyuan.zhang at amd.com>
>>>
>>> Signed-off-by: Boyuan Zhang <boyuan.zhang at amd.com>
>>
>> Reviewed-by: Christian König <christian.koenig at amd.com>
>>
>>> ---
>>>   src/gallium/drivers/radeon/radeon_video.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/gallium/drivers/radeon/radeon_video.c
>>> b/src/gallium/drivers/radeon/radeon_video.c
>>> index 605a2c7..02e8dcf 100644
>>> --- a/src/gallium/drivers/radeon/radeon_video.c
>>> +++ b/src/gallium/drivers/radeon/radeon_video.c
>>> @@ -221,7 +221,7 @@ int rvid_get_video_param(struct pipe_screen 
>>> *screen,
>>>       if (entrypoint == PIPE_VIDEO_ENTRYPOINT_ENCODE) {
>>>           switch (param) {
>>>           case PIPE_VIDEO_CAP_SUPPORTED:
>>> -            return codec == PIPE_VIDEO_FORMAT_MPEG4_AVC &&
>>> +            return profile == PIPE_VIDEO_PROFILE_MPEG4_AVC_BASELINE &&
>>>                   rvce_is_fw_version_supported(rscreen);
>>>           case PIPE_VIDEO_CAP_NPOT_TEXTURES:
>>>               return 1;
>>
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>